That is the best Scizor moveset for raw DPS, but has little use in the current meta. My (currently only one) Scizor has the same double steel moveset too.
A double bug moveset would be much better, as it can at least be used as an Exeggutor prestiger (Scizor also resists all of Exeggutor's moves). The current double bug moveset (FC/XS) is the fastest moveset in the game currently, great for dodging.
Scizor
Alright, so i actually hatched my first 80%+ Scyther and it actually was 89% (12/14/14) I evolved him immediatley and got Bullet Punch/ Iron Head. This website has that as an optimal attacking moveset. Has Scizor in the 4th tier of attackers, which i will gladly take. But in which situation would you all use him? Which common Pokemon could i attack with him? Steel apparently has little Weakness. According to this page, everything is Resistant or Normal effect to except fire.
Answers
I asked the exact same question a while ago. Since then I tested him here and there and found out that he is a decent generalist. Since Im missing alot of key attackers he became rly useful to fill the party slots when I dont have anything better. Hes dps is pretty alright and I didnt power him up so hes still just below the 1600 cp mark. Dont forget steel is SE against rock but so is rock against bug so rhydon and trex are tricky matchups for him.