The additional health of the Vaporeon only helps in that you might be able to fight multiple rounds before "spending time to use healing potions"
However, you loose time, as Golduck hits harder. I would assume that the effective defense of golduck might also be marginally higher, so the total amount of potions should be similar, and maybe even in favour of Golduck.
I'd say use Golduck!