There are really only a few pokemon I would ever recommend using as your buddy, everything else is suboptimal considering you will catch / hatch them regularly. Here's my buddy ranking, but it's open to interpretation based on biome:
- Snorlax
- Chansey
- Dratini
- Larvitar
Snorlax and Chansey are probably the best choices in my opinion, but if you're in a desert biome for example, you may give less weight to Chansey candies. Dratini and Larvitar can be swapped around based on biome, but I give those less importance than Snorlax / Blissey because they can be "farmed' a lot easier.
I would pretty much never have a buddy that isn't one of the above pokemon.