Electivire Question

The wording "quite lackluster" there is quite an overstatement. It's attack is fine. The answer basically depends on what it always depends on: are you in need of an electric attacker right now?
As a general rule of thumb, you are discouraged from evolving or powering up anything unless you really need it since patience has always been the most rewarding factor when dealing with these things; whether it is because of possible CDs (not reliably likely in this case) or simply because you might get a better specimen down the line when you actually need that specific Mon in your lineup.
This goes for everything: People are unreasonably afraid of powering up their Groudon and Kyogre because of the uncertain possibility that they might get their exclusive moves one day, thus making their current ones "obsolete" and therefore a "waste of resources". But is it really a waste if they made good use of them during that time? My judgement says no, it isn't a waste at all, as long as they were serviceable during their prime. If you, however, evolve and/or max a Pokemon and never use it at all and one day it is granted an RD or a CD and it's species becomes meta-relevant, then yeah, you could probably say that you wasted your resources in vain.