Lucky Egg Catch or Evovle

I think it definitely does make sense. It just makes better sense to mass evolve! It all depends on how many lucky eggs you have. If you have then, there's no better time to use them than now!

If you are not in an area where you can continuously catch pokemon (either naturally high spawn rates or with lures), then you could at least have some evolutions ready to fill in some downtime.

One evolution gives 500 XP, one perfect catch (curved excellent first throw) gives 260 XP. So you'd need to constantly catch pokemon for 30 minutes and score an excellent on your first ball on every single one of them for it to be worth it, and even then I don't think you can do that fast enough (two catches within the timeframe of one evolution)

Of course, if you buy 25 or more lucky eggs, go ahead and use some while playing on lures since you'll still have more left to use with evolutions.

Since your storage is limited, no matter how much candy/mons you saved up, sooner or later you have to combine evolving with hatching.